-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update travis xcode version #19475
update travis xcode version #19475
Conversation
fe9fa20
to
f740f10
Compare
I'll close my PR for this then. Thanks! |
Good catch @vtjnash, thanks for looking into this. |
Somehow still the same error? |
f740f10
to
cae3f88
Compare
I forgot a semicolon |
84424cd
to
6c082f5
Compare
brew install -v cmake staticfloat/juliadeps/libgfortran; | ||
brew install -v --only-dependencies --HEAD julia; | ||
brew install cmake staticfloat/juliadeps/libgfortran; | ||
brew install --only-dependencies --HEAD julia; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when this fails we will want to know why, please put this back
fde570b
to
f6cd0c1
Compare
SIP prevents the DYLD variables from being passed to make via the environment so pass it via the arguments instead
f6cd0c1
to
156edb4
Compare
Looks like you got it! Nice work! 💯 |
Yay! Finally got the syntax right to make bash happy. Thanks for the original PR too, it helped with the debugging. |
make $BUILDOPTS -C contrib -f repackage_system_suitesparse4.make; | ||
TESTSTORUN="all --skip linalg/triangular subarray"; fi # TODO: re enable these if possible without timing out | ||
- git clone -q git://git.kitenet.net/moreutils | ||
script: | ||
- echo $BUILDOPTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't necessary to have in all build logs
- make -C moreutils mispipe | ||
- make $BUILDOPTS -C base version_git.jl.phony | ||
# capture the log, but only print it if `make deps` fails | ||
# try to show the end of the log first, because this log might be very long (> 4MB) | ||
# and thus be truncated by travis | ||
- moreutils/mispipe "make $BUILDOPTS VERBOSE=0 -C deps 2> deps-err.log" "$BAR" > deps.log || | ||
- moreutils/mispipe "make \$BUILDOPTS VERBOSE=0 -C deps 2> deps-err.log" "$BAR" > deps.log || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't work, it prevents parallel builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? how? this is critical for ensuring that the interpolation happens at the right time for the macOS build to succeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildopts is getting ignored completely at this step. no interpolation is needed at this step, the deps don't need the redefinition of spawn. between merging this pr and my partial reversion of it it was impossible to rebuild from a fresh cache without timing out, due to building all deps in serial and building two copies of llvm (one with assertions and one without). this was broken, clean cache builds do go through in time now with it partially reverted
SIP prevents the DYLD variables from being passed to make via the environment
so pass it via the arguments instead